Change the default location of the 'enabled_plugins' file #2298
Conversation
HoloRin
force-pushed
the
enabled_plugins_2234
branch
from
bb604c8 to
9927b60
Compare
|
This PR should fix this issue - |
| rabbit_env:log_context(Context2), | ||
|
|
||
| %% Migrate the enabled_plugins file to the new location if necessary | ||
| Context3 = rabbit_plugins:maybe_migrate_enabled_plugins_file(Context2), |
There was a problem hiding this comment.
The rabbitmq_prelaunch application can't depend on a module from rabbit. The dependency is the other way around.
You could move the code you added to rabbit_plugins to a new rabbitmq_prelaunch_plugins module in the rabbitmq_prelaunch application for instance.
There was a problem hiding this comment.
Ok, that makes sense.
I see we don't appear to separate the prelaunch app's tests into their own directory? So I will leave the rabbit_plugins_SUITE in test/ as rabbit_prelaunch_plugins_SUITE instead of placing it in apps/rabbit_prelaunch/test.
During prelaunch, if an explicit plugins file location has not been specified via the RABBITMQ_ENABLED_PLUGINS_FILE env var, adopt a new location of /var/lib/rabbitmq/enabled_plugins if possible, but fallback to the original location if there is no file at the new location, and the file at the old location is both readable and writable. No change is applied for Windows.
apps/rabbit_prelaunch should not depend on rabbit, since rabbit already depends on apps/rabbit_prelaunch. So, rabbit_plugins:maybe_migrate_enabled_plugins_file/1 becomes rabbit_prelaunch_plugins:maybe_migrate_enabled_plugins_file/1.
HoloRin
force-pushed
the
enabled_plugins_2234
branch
from
3852035 to
fc18ca9
Compare
|
My recollection was that there were some additional unwanted side effects stemming from these changes. Since has been sitting for quite some time, I think the issue is best closed. |
During prelaunch, if an explicit plugins file location has not been specified via the
RABBITMQ_ENABLED_PLUGINS_FILEenv var, adopt a new location of/var/lib/rabbitmq/enabled_pluginsif possible, but fallback to the original location if there is no file at the new location, and the file at the old location is both readable and writable. It the file at the old location is strictly readable, we copy it to the new location and log a message.No change is applied for Windows, since the Windows
config_base_diranddata_dirdefault to the same location and there is effectively no change.