Ensures pending counter in rabbit_shovel_status is always an integer (backport #14614) #14710
+167
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We observed that when a shovel connection for AMQP091 run into blocked state, pending messages stack up in a list of messages, which leads to the response of
rabbitmq_shovel_status:status()
can get very large and can cause memory leaks with many shovels (or one shovel usingno-ack
). It also breaks the management UI for shovel status.steps to reproduce:
rabbitmq_shovel_status:status()
on the source will show pending as a list of messages.rabbitmq_shovel_status:status()
will show #{pending => {[],[]},This PR ensures that the number of pending messages is an integer for all shovel protocols. I have tried confirming if the bug exist in AMQP1.0, however I get other issues then which I am currently investigating.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.
This is an automatic backport of pull request #14614 done by [Mergify](https://mergify.com).