Require MQTT feature flags in 4.0 #11642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
force-pushed
the
ff_delete_ra_cluster_mqtt_node
branch
from
6f95096 to
c9d5e1d
Compare
ansd
changed the title
Require all MQTT feature flags and remove their compatibility code: * delete_ra_cluster_mqtt_node * rabbit_mqtt_qos0_queue * mqtt_v5 These feature flags were introduced in or before 3.13.0.
ansd
force-pushed
the
ff_delete_ra_cluster_mqtt_node
branch
from
c9d5e1d to
b6539bd
Compare
acogoluegnes
approved these changes
Jul 10, 2024
ansd
added a commit
that referenced
this pull request
Jul 30, 2024
This code should have been deleted as part of #11642
Merged
ansd
added a commit
that referenced
this pull request
Jul 30, 2024
This code should have been deleted as part of #11642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since feature flag
message_containersintroduced in 3.13.0 is required in 4.0, we can also require all MQTT feature flags (since they were introduced in or before 3.13.0) and remove their compatibility code:delete_ra_cluster_mqtt_noderabbit_mqtt_qos0_queuemqtt_v5