Skip to content

Deletion of unreachable code #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Deletion of unreachable code #847

merged 1 commit into from
May 25, 2020

Conversation

@Pliner
Copy link
Contributor

@Pliner Pliner commented May 24, 2020 •
edited
Loading

Proposed Changes

Deletion of unreachable code

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@Pliner Pliner marked this pull request as ready for review May 25, 2020 04:21
@Pliner Pliner changed the title Delete unreachable code Deletion of unreachable code May 25, 2020
@michaelklishin michaelklishin merged commit 20d81b1 into rabbitmq:master May 25, 2020
michaelklishin added a commit that referenced this pull request May 25, 2020
@michaelklishin
Merge pull request #847 from Pliner/remove-unreachable-code
dee726a 
Deletion of unreachable code

(cherry picked from commit 20d81b1)
@michaelklishin
Copy link
Contributor

Backported to 6.x. Thank you!

@michaelklishin michaelklishin mentioned this pull request May 25, 2020
Merged
11 tasks
@Pliner Pliner deleted the remove-unreachable-code branch May 25, 2020 18:37
@lukebakken lukebakken added this to the 6.1.0 milestone May 26, 2020
@lukebakken lukebakken self-assigned this May 26, 2020
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Aug 5, 2025
Open
Closed
This was referenced Aug 17, 2025
Closed
Closed
This was referenced Sep 15, 2025
Closed
Open
Closed
@dependabot dependabot bot mentioned this pull request Oct 6, 2025
Open
This was referenced Oct 20, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@lukebakken lukebakken

Labels

None yet

Projects

None yet

Milestone

6.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Pliner @michaelklishin @lukebakken