Skip to content

Conversation

@stebet
Copy link
Contributor

@stebet stebet commented May 19, 2020

Proposed Changes

Fixes #838 by making sure all asynchronous event handlers are run.

Types of Changes

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@lukebakken lukebakken self-assigned this May 20, 2020
@lukebakken lukebakken added this to the 6.1.0 milestone May 20, 2020
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stebet

@lukebakken lukebakken merged commit 9964644 into rabbitmq:master May 20, 2020
@michaelklishin
Copy link
Contributor

@stebet thank you for your ongoing contributions 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The implementation of the AsyncEventingBasicConsumer is not safe when there are multiple handlers attached

3 participants