Add NRT for the whole client assembly

[bollhals]

Proposed Changes

Fixes #1596
Fixes #1622

Enables Nullable Reference Types in the client assembly

I realize a bit late that you intended to do this in 8.0 ... unfortunately I already was 80% through when I did see it 💯

You'll have to decide whether it's worth including it or push it after the snap for 7.0

Types of Changes

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

How does it work with the PublicAPI thing, does this need adjustment as well?

[bollhals]

@lukebakken Any idea what I broke with the public api analyzer that it reports internals on the netstandard2.0 target?

[lukebakken]

@bollhals somehow this check started to work:

dotnet_diagnostic.RS0051.severity = error

I disabled it (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.md#rs0051-add-internal-types-and-members-to-the-declared-api)

[lukebakken]

@bollhals @lechu445 - anything else? I plan to merge this by 0900PDT today.

[lechu445]

@lukebakken nothing more from my side. LGTM

[bollhals]

@bollhals @lechu445 - anything else? I plan to merge this by 0900PDT today.

With your recent commit, not from my side.
Hope it is all annotated corectly 🤞

[lukebakken]

@bollhals @lechu445 @paulomorgado thank you so much for your insights and contributions here 🥇

[lukebakken]

@ngbrown it appears to be converted - https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/Impl/RabbitMQActivitySource.cs

[ngbrown]

@lukebakken yes, you are correct. I had thought I had copied out the most recent version, but evidently not. Sorry about bothering you.

[lukebakken]

@ngbrown no worries at all! If you're testing out the v7 RC candidates, we would appreciate any feedback you have. Thanks!