Skip to content

Conversation

@lukebakken
Copy link
Collaborator

@lukebakken lukebakken self-assigned this Jun 27, 2024
@lukebakken lukebakken added this to the 7.0.0 milestone Jun 27, 2024
@lukebakken lukebakken marked this pull request as ready for review June 27, 2024 21:38
Reported here:
https://groups.google.com/g/rabbitmq-users/c/hk5pJ4cKF0c

* Ensure that arguments passed to a queue, exchange, binding, or consumer are copied when being recorded.
@lukebakken lukebakken force-pushed the rabbitmq-users-hk5pJ4cKF0c branch from 822850e to 870a1f4 Compare June 27, 2024 21:38
@lukebakken lukebakken merged commit 89d472d into main Jun 27, 2024
@lukebakken lukebakken deleted the rabbitmq-users-hk5pJ4cKF0c branch June 27, 2024 22:12
@Saibamen Saibamen mentioned this pull request Jun 27, 2024
lukebakken pushed a commit to Saibamen/rabbitmq-dotnet-client that referenced this pull request Jun 27, 2024
Fixes rabbitmq#1617

Update RecordedConsumer.cs
Update RecordedExchange.cs
Update RecordedQueue.cs
Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs
Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs
Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs
Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs
Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs
Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs
Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs
Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs
Update `TestRecoveringConsumerHandlerOnConnection_EventArgumentsArePassedDown`
Update projects/Unit/TestConnectionRecovery.cs
lukebakken pushed a commit to Saibamen/rabbitmq-dotnet-client that referenced this pull request Jun 28, 2024
Fixes rabbitmq#1617

Update RecordedConsumer.cs
Update RecordedExchange.cs
Update RecordedQueue.cs
Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs
Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs
Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs
Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs
Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs
Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs
Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs
Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs
Update `TestRecoveringConsumerHandlerOnConnection_EventArgumentsArePassedDown`
Update projects/Unit/TestConnectionRecovery.cs

Port test from `main`
lukebakken added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants