Skip to content

fix some quick wins #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix some quick wins #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions projects/RabbitMQ.Client/client/RentedMemory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,23 +68,17 @@ internal readonly ReadOnlyMemory<byte> CopyToMemory()
return new ReadOnlyMemory<byte>(Memory.ToArray());
}

private void Dispose(bool disposing)
public void Dispose()
{
if (!_disposedValue)
{
if (disposing && RentedArray != null)
if (RentedArray != null)
{
ArrayPool<byte>.Shared.Return(RentedArray);
}

_disposedValue = true;
}
}

public void Dispose()
{
Dispose(disposing: true);
GC.SuppressFinalize(this);
}
}
}
5 changes: 1 addition & 4 deletions projects/RabbitMQ.Client/client/impl/ChannelBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,10 +1069,7 @@ await _confirmSemaphore.WaitAsync(cancellationToken)

try
{
var cmd = new BasicPublishMemory(
Encoding.UTF8.GetBytes(exchange),
Encoding.UTF8.GetBytes(routingKey),
mandatory, default);
var cmd = new BasicPublish(exchange, routingKey, mandatory, default);
using Activity sendActivity = RabbitMQActivitySource.PublisherHasListeners
? RabbitMQActivitySource.Send(routingKey, exchange, body.Length)
: default;
Expand Down