Fix two flaky tests #1579
Merged
Fix two flaky tests #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/fix-basic-roundtrip-tests
branch
from
3cfa2bc to
6ea27cf
Compare
projects/RabbitMQ.Client/client/impl/ConsumerDispatching/ConsumerDispatcherBase.cs
Outdated
Show resolved
Hide resolved
projects/RabbitMQ.Client/client/impl/ConsumerDispatching/ConsumerDispatcherBase.cs
Outdated
Show resolved
Hide resolved
These two tests always fail at the same time, too 🤔 * Re-try when using HTTP API to close a connection and an error happens * Introduce `ShortSpan` wait span. * Ensure that message is actually routed and confirmed before checking. * Limit client provided name to 3000 characters * Add callback exception handlers to flaky tests * Check for null consumer tag based on CI failures. * No need for random data, just different data. Update projects/RabbitMQ.Client/client/impl/ConsumerDispatching/ConsumerDispatcherBase.cs Co-authored-by: Paulo Morgado <[email protected]>
lukebakken
force-pushed
the
lukebakken/fix-basic-roundtrip-tests
branch
from
cbcc643 to
a8825c6
Compare
michaelklishin
approved these changes
May 25, 2024
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests always fail at the same time, too 🤔