Skip to content

Add govulncheck to makefile and github actions. #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Add govulncheck to makefile and github actions. #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,20 @@ on:
pull_request:
branches: [ main ]

env:
GO_VERSION: '^1.19.0' # Require Go 1.19 and above, but lower than Go 2.0.0

jobs:

unit_tests:
name: unit tests
runs-on: ubuntu-latest
container: us.gcr.io/cf-rabbitmq-for-k8s-bunny/rabbitmq-for-kubernetes-ci
steps:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: ${{ env.GO_VERSION }}
- name: Check out code into the Go module directory
uses: actions/checkout@v2
- name: Unit tests
Expand All @@ -29,7 +36,7 @@ jobs:
uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: '^1.19.0' # Require Go 1.16 and above, but lower than Go 2.0.0
go-version: ${{ env.GO_VERSION }}
- name: System tests
env:
K8S_VERSION: ${{ matrix.k8s }}
Expand Down
13 changes: 9 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ install-tools:
@echo "Install all tools..."
@awk -F '"' '/_/ && !/k8s.io\/code-generator/ { system("go install " $$2) }' tools/tools.go
@$(get_mod_code_generator)
go install golang.org/x/vuln/cmd/govulncheck@latest

ENVTEST_K8S_VERSION = 1.22.1
ARCHITECTURE = amd64
Expand Down Expand Up @@ -49,11 +50,11 @@ $(KUBEBUILDER_ASSETS):
### Targets

.PHONY: unit-tests
unit-tests: install-tools $(KUBEBUILDER_ASSETS) generate fmt vet manifests ## Run unit tests
unit-tests: install-tools $(KUBEBUILDER_ASSETS) generate fmt vet vuln manifests ## Run unit tests
ginkgo -r --randomize-all api/ internal/ rabbitmqclient/

.PHONY: integration-tests
integration-tests: install-tools $(KUBEBUILDER_ASSETS) generate fmt vet manifests ## Run integration tests
integration-tests: install-tools $(KUBEBUILDER_ASSETS) generate fmt vet vuln manifests ## Run integration tests
ginkgo -r --randomize-all controllers/

just-integration-tests: $(KUBEBUILDER_ASSETS) vet
Expand All @@ -65,7 +66,7 @@ system-tests: ## run end-to-end tests against Kubernetes cluster defined in ~/.k
NAMESPACE="rabbitmq-system" ginkgo --randomize-all -r system_tests/

# Build manager binary
manager: generate fmt vet
manager: generate fmt vet vuln
go build -o bin/manager main.go

# Run against the configured Kubernetes cluster in ~/.kube/config
Expand All @@ -75,7 +76,7 @@ manager: generate fmt vet
# https://github.com/telepresenceio/telepresence is one way to do this (just run
# `telepresence connect` and services like `test-service.test-namespace.svc.cluster.local`
# will resolve properly).
run: generate fmt vet manifests just-run
run: generate fmt vet vuln manifests just-run

just-run: ## Just runs 'go run main.go' without regenerating any manifests or deploying RBACs
KUBE_CONFIG=${HOME}/.kube/config OPERATOR_NAMESPACE=rabbitmq-system ENABLE_WEBHOOKS=false go run ./main.go
Expand Down Expand Up @@ -134,6 +135,10 @@ fmt:
vet:
go vet ./...

# Run govulncheck
vuln:
govulncheck ./...

# Generate code & docs
generate: install-tools api-reference
controller-gen object:headerFile="hack/NOTICE.go.txt" paths="./..."
Expand Down