Update PR workflow to use latest k8s #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Kubernetes version to latest available and lowest supported (N-2). Match Go version with our `go.mod`. Bump Cert Manager to 1.7.0 because 1.8.0 has breaking changes, and we have not tested whether we are compatible with those changes. Sometimes, Cert Manager Pods become ready, however Cert Manager itself is not ready to serve requests. If Topology Operator is deployed at that time, Cert Manager will not inject the certificate into the Webhooks, causing an error of the kind "x509: certificate signed by unknown authority". The solution is to wait for the API to be ready, using their new CLI `cmctl`.
Zerpet
force-pushed
the
update-pr-workflow
branch
from
4779e90 to
a97917a
Compare
coro
approved these changes
Jun 14, 2022
Zerpet
added a commit
that referenced
this pull request
Jun 14, 2022
Follow up to #395 PR. Make targets that use cmctl CLI should `make` it as a dependency. Signed-off-by: Aitor Perez Cedres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
go.modAdditional Context
Cert Manager Pods may become ready before Cert Manager API is ready. This results in a failed Top-Op deployment with an error like
x509: certificate signed by unknown authority. The workaround is to check and wait for Cert Manager API to become ready.