Skip to content

Conversation

@ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Jun 10, 2022

PR as part of issue: https://github.com/rabbitmq/service-operator-experience/issues/64

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

Two small changes

  • more general fields descriptions on SecretBackend so it can be reused in standby replication operator
  • correct a unit tests description

Additional Context

- the same type is used in standby replication as well;
remove schema sync replication mentions so the descriptions
also make sense for standby replication
- description was incorrect: update is not allowed and that's
what the test is verifying
@ChunyiLyu ChunyiLyu merged commit dc15ff4 into main Jun 10, 2022
@ChunyiLyu ChunyiLyu deleted the better-fields-descriptions branch June 10, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants