Support referencing a vault secret path to configure schema sync credentials #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- error string was duplicated. For example: "error": "unable to retrieve credentials from secret store: unable to read Vault secret: unable to read Vault secret:
coro
approved these changes
Jun 7, 2022
| "do not provide both secretBackend.vault.secretPath and upstreamSecret")) | ||
| } | ||
|
|
||
| if s.Spec.UpstreamSecret == nil && s.Spec.SecretBackend.Vault == nil { |
There was a problem hiding this comment.
This doesn't catch Vault being non-nil but with the secret unset, e.g.:
---
apiVersion: rabbitmq.com/v1beta1
kind: SchemaReplication
metadata:
name: upstream
spec:
endpoints: "test:134556"
secretBackend:
vault: {}
rabbitmqClusterReference:
name: hello-worldThis is later caught in the controller, but it's not validated upfront by this webhook.
There was a problem hiding this comment.
Good point and updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #386
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Users will be able to reference a vault secret path
spec.secretBackend.vault.secretPathto configure username and password for schema sync parameters.spec.secretBackend.vault.secretPathis updatableAdditional Context