This commit override security context in system tests for openshift. #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
over_security_context_system_tests_openshift
branch
from
f4cef68 to
d0f6eef
Compare
coro
approved these changes
Jun 1, 2022
Contributor
coro
left a comment
coro
left a comment
There was a problem hiding this comment.
Approved, save for the one comment, just as with the other PR.
system_tests/utils.go
Outdated
| return cluster | ||
| } | ||
|
|
||
| func overrideSecurityContextForOpenshift(cluster *rabbitmqv1beta1.RabbitmqCluster) *rabbitmqv1beta1.RabbitmqCluster { |
Contributor
There was a problem hiding this comment.
Same comment with this function signature as the other PR.
DanielePalaia
force-pushed
the
over_security_context_system_tests_openshift
branch
from
d0f6eef to
cc78fd2
Compare
Zerpet
reviewed
Jun 1, 2022
Member
Zerpet
left a comment
Zerpet
left a comment
There was a problem hiding this comment.
Content looks good. Same comment regarding signing with your personal gmail account. I don't feel too strong about ending the subject line with a period, but it is not one of the best practices 🙂
DanielePalaia
force-pushed
the
over_security_context_system_tests_openshift
branch
from
cc78fd2 to
2bf0238
Compare
Overriding rabbitmq cluster security context in system-tests when running in Openshift. RABBITMQ_IMAGE env variable is introduced to override the image of the rabbitmq cluster created by the system-tests RABBITMQ_IMAGE_PULL_SECRET is introduced to override the image pull secret and allow to run the system-tests on a commercial version.
DanielePalaia
force-pushed
the
over_security_context_system_tests_openshift
branch
from
2bf0238 to
d9c3f2b
Compare
Contributor
Author
|
@Zerpet: Amended the author, put a better commit message! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env variable ENVIRONMENT is checked to see if we are running agaist an openshift K8S.
This is due to run our system-tests in a pipeline against openshift.
RABBITMQ_IMAGE env variable is introduced like the cluster-operator in order to override the image of the rabbitmq cluster created by the system-tests
Also RABBITMQ_IMAGE_PULL_SECRET is introduced like the cluster-operator to override the image pull secret and allow us to run the system-tests on a commercial version
This closes #
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Additional Context