Temporary fix on deletion_system_test in order to avoid to create a m… #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irror queue in a one pod cluster causing the pod to get stuck in "terminating" phase and preventing our pipeline to work. It can be reverted once await_online_synchronized_mirror get fixed to manage this case
coro
approved these changes
Apr 20, 2022
Zerpet
requested changes
Apr 20, 2022
There was a problem hiding this comment.
I'd much rather mark the test as "skip" than giving us a false sense of successful test.
I think the test has caught a legitimate bug, in the Core in this case. If we want to make the pipeline green, we should just skip this test. Ginkgo gives this skip functionality.
…irror queue in a one pod cluster causing the pod to get stuck in "terminating" phase and preventing our pipeline to work. It can be reverted once await_online_synchronized_mirror get fixed to manage this case
Zerpet
reviewed
Apr 21, 2022
There was a problem hiding this comment.
Do you mind using the pointer module to create the int pointer?
We use it in other parts of the code and it's best to keep it consistent around the code base.
…irror queue in a one pod cluster causing the pod to get stuck in "terminating" phase and preventing our pipeline to work. It can be reverted once await_online_synchronized_mirror get fixed to manage this case
|
No, that's of course fine! Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…irror queue in a one pod cluster causing the pod to get stuck in "terminating" phase and preventing our pipeline to work.
It can be reverted once await_online_synchronized_mirror get fixed to manage this case
Not really a temporary fix anymore, putting grace period to a lower value will increase the stability of this test in general, as the scope is to delete objects when the rabbimq cluster get deleted.
This closes #
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Additional Context