Add SuperStreamCRD #281
Merged
Add SuperStreamCRD #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
reviewed
Jan 10, 2022
Zerpet
reviewed
Jan 13, 2022
Member
Zerpet
left a comment
Zerpet
left a comment
There was a problem hiding this comment.
Feel free to ignore all my nit picks 🙈
Comment on lines
+12
to
+16
| namespace: system | ||
| name: webhook-service | ||
| path: /convert | ||
| conversionReviewVersions: | ||
| - v1 |
Member
There was a problem hiding this comment.
I was about to comment that we don't want a conversion webhook, and I just noticed the files are placed there, but not actually used 🙂 Leaving this comment here in case other reviewer runs into the same confusion.
Zerpet
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the successor of #263 , including only the SuperStreamCRD. The more experimental SuperStreamConsumer CRD will be included in a separate controller once this PR is merged, so that the topology operator does not end up with permissions to manage Pods.