Bump k8s api 1.22 #262
Merged
Bump k8s api 1.22 #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump to latest controller-tools, controller-runtime - controller-gen now does not support CRD v1beta1 and crd options such as trivialVersions and preserveUnknownFields are not necessary anymore
MirahImage
approved these changes
Dec 8, 2021
coro
suggested changes
Dec 8, 2021
Contributor
coro
left a comment
coro
left a comment
There was a problem hiding this comment.
LGTM. Can you also change ./docs/api/autogen/config.yaml to match the new version and generate the API reference docs again with make api-reference?? Thanks!
coro
approved these changes
Dec 8, 2021
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Note pending to be discussed in next team sync up, together with PR in Cluster Operator rabbitmq/cluster-operator#913
Additional Context