Skip to content

Conversation

@ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Sep 29, 2021

This closes #248

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

TLS system test can give false positive, defailed report see issue: #248

This PR:

  • changes the order of setup in TLS system tests, so that the test creates the TLS RMQ cluster after tls secrets were already created and in place. This way, the cluster doesn't have to restarted in the middle of the test (restart is due to DisableNonTLSListeners were updated to true, which updates list of open ports and TLS probe port of the statefulset).
  • verifies successful create of the policy by asserting on status condition. Previously the test only verifies a non error return from k8s client which is not sufficient.

Additional Context

- tls system test can give false positive, defailed report
see issue: #248
@ChunyiLyu ChunyiLyu changed the title Verify successful create of the object in TLS system tests Verify successful create of the policy object in TLS system tests Sep 29, 2021
@ChunyiLyu ChunyiLyu merged commit aa8d783 into main Sep 29, 2021
@ChunyiLyu ChunyiLyu deleted the tls-sys-test branch September 29, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS system test can have false positive result

3 participants