Skip to content

Conversation

newmanjeff
Copy link

Proposed Changes

Moves the rebar3_hex plugin from "plugins" to "project_plugins." Including the plugin within the "plugin" section means all projects the include credentials-obfuscation as a dependency must also include the rebar3_hex plugin. Note the documentation:

NOTE : Be sure not to add rebar3_hex to the plugins section within a projects rebar3 config as this will become a dependency for others downloading your package from hex.pm

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Remove rebar3_hex plugin from rebar.config #22
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@michaelklishin michaelklishin merged commit a08e67f into rabbitmq:main Nov 16, 2022
@michaelklishin
Copy link
Contributor

Thank you. I'll cut a new release some time tomorrow.

@isaacsanders
Copy link

@michaelklishin A new release was never made

@lukebakken lukebakken self-assigned this Mar 4, 2023
@lukebakken lukebakken added this to the 3.3.0 milestone Mar 4, 2023
@lukebakken
Copy link
Contributor

@isaacsanders I'm getting the release now.

@lukebakken
Copy link
Contributor

@isaacsanders
Copy link

@isaacsanders I'm getting the release now.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants