Submitted on behalf of @luos: Implement fallback secret #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to set a secondary secret to be able to migrate between multiple secret values. API was kept to be compatible with previous behaviour, ie. strings are converted to binaries. Encrpyted values are now wrapped to be able to identify when a decryption failed, as if the secret is invalid, it may succeed and return junk data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am submitting a PR for a branch from @luos' fork that's under the core team review.
I have participated in discussions around it but authored no code at the time
of submission.
Add possibility to set a secondary secret to be able to migrate between
multiple secret values.
API was kept to be compatible with previous behaviour, ie. strings are
converted to binaries.
Encrypted values are now wrapped to be able to identify when a
decryption failed, as if the secret is invalid, it may succeed and
return junk data.