Print method for memoised functions #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/memoise.r
Outdated
Member
There was a problem hiding this comment.
Would be a little simpler as
cat("Memoised function:\n")
print(environment(x)$f)
Member
Author
There was a problem hiding this comment.
Yes you are right, the current form was a holdover to my first iteration which used message() instead of cat(). I decided cat() was more consistent with the existing behavior, but did not re-simplify. Thanks!
Member
Author
|
jimhester@088416b is ready, I added a note to NEWS.md and ran roxygen, which fixed the previous error on travis due to an unexported print method. |
jimhester
added a commit
that referenced
this pull request
Jan 19, 2016
Print method for memoised functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default print method for memoised functions wasn't very useful, as you couldn't see the function definition, just the memoised part.
This simply calls the input functions print method along with adding a note that the function in memoised.