Allow invalid xml #560
Merged
Allow invalid xml #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
approved these changes
Nov 5, 2020
Collaborator
AshesITR
left a comment
AshesITR
left a comment
There was a problem hiding this comment.
I checked for other uses of xml_parsed_content (and global_xml_parsed_content()).
All other users already did NULL checks, these were:
- object_name_linter
- object_usage_linter
- pipe_continuation_linter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559
Since lintr might pass a partial or invalid parse data to
xmlparsedata::xml_parse_data, it could also generate invalid XML text, which also causesxml2::read_xml()to fail.This PR adds a
tryCatch()to allxml2::read_xml(xmlparsedata::xml_parse_data(pc))so that invalid XML text would not causelintr::lintto fail.Note that all linters that uses the
source_file$xml_parsed_contentmust check if it isNULLbefore querying it. This PR adds such checks toseq_linter,missing_package_linterandnamespace_linter.