361 cyclocomp linter #396
361 cyclocomp linter #396
Conversation
incurs dependency on cyclocomp. closes #361.
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=========================================
Coverage ? 82.37%
=========================================
Files ? 42
Lines ? 1889
Branches ? 0
=========================================
Hits ? 1556
Misses ? 333
Partials ? 0
Continue to review full report at Codecov.
|
| line_number = source_file[["line"]][1], | ||
| column_number = source_file[["column"]][1], | ||
| type = "style", | ||
| message = paste0( |
There was a problem hiding this comment.
I think this is too long, maybe
"functions should have cyclomatic complexity of less than", complexity_limit, "."
|
I think this looks good, thanks! Can you please add a bullet to NEWS? It should briefly describe the change and end with |
|
It looks like you have a few test failures, once those are fixed and we have a clean build this can be merged. |
sorry about that, forgot to update the tests to the new message... 🙈 |
|
Great work, this package is now better thanks to you! |
2 participants
adds (function-wise) linting for cyclomatic complexity.
computes cyclomatic complexity for each entry in
source_files$expressions.incurs a dependency on
cyclocomp.closes #361.
Not sure if the generated message is too verbose for your taste, I figured it's ok since this will only be generated at most once for any top-level expression in each file.