Skip to content

Conversation

@jabranham
Copy link
Contributor

Adds a linter that checks for e.g. x == NA rather than is.na(x). Added to default linters.

Let me know if something isn't clear or if I need to change something.

Closes #143

@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #326 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   85.41%   85.64%   +0.22%     
==========================================
  Files          40       41       +1     
  Lines        2098     2131      +33     
==========================================
+ Hits         1792     1825      +33     
  Misses        306      306
Impacted Files Coverage Δ
R/zzz.R 0% <ø> (ø) ⬆️
R/equals_na_lintr.R 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bc6b6...f1d9cc1. Read the comment docs.

@jimhester
Copy link
Member

Thanks! Could you add a note to NEWS.md mentioning this addition with your GitHub handle and the issue number?

@jabranham
Copy link
Contributor Author

Sure, done. I also regenerated the documentation.

Just FYI, the NEWS.md file starts with 1.0.1.9001, but that's smaller than what's in DESCRIPTION, which says 1.0.2.9000.

@gdequeiroz gdequeiroz self-requested a review June 14, 2018 17:51
@gdequeiroz gdequeiroz added the feature a feature request or enhancement label Jun 14, 2018
@gdequeiroz
Copy link
Contributor

Just FYI, the NEWS.md file starts with 1.0.1.9001, but that's smaller than what's in DESCRIPTION, which says 1.0.2.9000.

@jabranham I noticed that. This version number shows when installing from gh: devtools::install_github("jimhester/lintr")

> packageVersion("lintr")
[1] ‘1.0.2.9000’

I don't know why. @jimhester can you help us here?

@jimhester
Copy link
Member

It is just outdated in the NEWS file and needs to be updated.

@jimhester
Copy link
Member

Thanks!

@jimhester jimhester merged commit bee2f34 into r-lib:master Jun 14, 2018
@jabranham jabranham deleted the equals_na_linter branch June 14, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature a feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants