Skip to content

Conversation

@MichaelChirico
Copy link
Collaborator

Based against #2438.

Closes #2047

Base automatically changed from todo-xml to main December 15, 2023 06:06
AshesITR
AshesITR previously approved these changes Dec 15, 2023
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable it for us? (Follow up is fine)

@MichaelChirico
Copy link
Collaborator Author

Hmm that blew up. Let me know if anything here should be split into its own PR.

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 15, 2023

Seems manageable to me. The comment fixes will probably be easy to review.
Maybe split off the xml_find_int() parts? Test failures seem to indicate that the migration is non-trivial.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdbb9bf) 98.53% compared to head (adf16a7) 98.53%.

❗ Current head adf16a7 differs from pull request most recent head ba8f1d8. Consider uploading reports for the commit ba8f1d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2439   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         126      126           
  Lines        5671     5676    +5     
=======================================
+ Hits         5588     5593    +5     
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR
Copy link
Collaborator

LGTM. Ping when you want to merge this (to avoid tons of "Update branch" merges with the current set of PRs

@MichaelChirico
Copy link
Collaborator Author

LGTM. Ping when you want to merge this (to avoid tons of "Update branch" merges with the current set of PRs

g2g, btw, as long as there's no conflicts merge commits don't invalidate reviews. a bit hard to forecast which will cause conflicts OTOH.

@AshesITR AshesITR merged commit 4b59aac into main Dec 15, 2023
@AshesITR AshesITR deleted the todo-regex branch December 15, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

todo_comment_linter could get an argument for valid TODO patterns

4 participants