Skip to content

Conversation

@MichaelChirico
Copy link
Collaborator

Part of #884

No hits on our package.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (984a399) 99.63% compared to head (9f93dbb) 99.64%.

❗ Current head 9f93dbb differs from pull request most recent head a3bceb7. Consider uploading reports for the commit a3bceb7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2274   +/-   ##
=======================================
  Coverage   99.63%   99.64%           
=======================================
  Files         114      115    +1     
  Lines        5258     5290   +32     
=======================================
+ Hits         5239     5271   +32     
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some metadata tests?

@MichaelChirico
Copy link
Collaborator Author

Maybe add some metadata tests?

Thanks; done. I guess we could discuss whether to land on {s}ample(1: or sample({1}:. Pretty much a toss-up to me.

@AshesITR
Copy link
Collaborator

I'd expect to land on the call to sample().

AshesITR
AshesITR previously approved these changes Nov 14, 2023
@MichaelChirico MichaelChirico merged commit 5674008 into main Nov 14, 2023
@MichaelChirico MichaelChirico deleted the sample_int branch November 14, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants