Add missing spaces around "and" in glue_collapse() #1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code LGTM! needs a news item (since this is present on CRAN) and a regression test would be good too. Thanks! |
|
Lints are unrelated to my changes. Should I fix them here or open another PR, wait for it to be merged and rebase? |
tests/testthat/test-with.R
Outdated
| mockery::stub( | ||
| linters_with_tags, | ||
| "available_linters", | ||
| data.frame(linter = c("fake_linter", "super_fake_linter"), package = "lintr", tags = "test") |
Codecov Report
@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
+ Coverage 98.86% 98.94% +0.08%
==========================================
Files 113 113
Lines 4939 4939
==========================================
+ Hits 4883 4887 +4
+ Misses 56 52 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
You can ignore them in this PR. #1879 handles this issue. |
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
MichaelChirico
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example error message at the moment: