New is_numeric_linter #1635
Merged
New is_numeric_linter #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
+ Coverage 98.31% 98.33% +0.01%
==========================================
Files 100 101 +1
Lines 4397 4443 +46
==========================================
+ Hits 4323 4369 +46
Misses 74 74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Resolved merge conflict. |
Collaborator
Author
thanks... FWIW I have a setting in my local got config that always resolves merges on our NEWS file correctly. shame I couldn't figure out how to make it work on the site last I checked |
Collaborator
Author
FYI this is my merge setting locally |
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #884
A few more odds & ends to tie up, filing early for any initial comments