Skip to content

refactor function_left_parentheses_linter() to XPath #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 26, 2022
Merged

refactor function_left_parentheses_linter() to XPath #1267

merged 5 commits into from
May 26, 2022

Conversation

@AshesITR
Copy link
Collaborator

@AshesITR AshesITR commented May 26, 2022 •
edited
Loading

fixes #1266

also improved location info and added tests for that.
renamed the file to function_left_parentheses_linter.R for consistency.

lintr::lint(text = "blah (1)", linters = function_left_parentheses_linter())

# on main
<text>:1:7: style: Remove spaces before the left parenthesis in a function call.
blah  (1)
      ^

# on pr
<text>:1:5: style: Remove spaces before the left parenthesis in a function call.
blah  (1)
    ^~

Will add a NEWS to #834 when this is merged.

AshesITR added 3 commits May 26, 2022 12:32
@AshesITR
refactor function_left_parentheses_linter() to XPath
ecc4694 
fixes #1266

also improved location info (I think?) and added tests for that.
renamed the file to function_left_parentheses_linter.R for consistency.
@AshesITR
document()
0c3c76f
@AshesITR
add missing .Rd from document()
89c62bd
MichaelChirico
MichaelChirico reviewed May 26, 2022
View reviewed changes
R/function_left_parentheses_linter.R
@@ -0,0 +1,32 @@
#' Function left parentheses linter
Copy link
Collaborator

@MichaelChirico MichaelChirico May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it didn't pick up the rename... a shame for the got history...

Copy link
Collaborator Author

@AshesITR AshesITR May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do an interactive rebase to split the rename from the modifications?

@AshesITR AshesITR merged commit 02b25b1 into main May 26, 2022
@AshesITR AshesITR deleted the xpath/function_left_parentheses branch May 26, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

function_left_parentheses_linter() to XPath

3 participants

@AshesITR @MichaelChirico