Add composite aggregation #2714
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@rdettai-sk I refactored aggregations in this PR: #2715 |
Contributor
Author
|
rdettai-sk
force-pushed
the
composite-as-aggreg
branch
from
e083a69 to
e7e2277
Compare
Contributor
Author
|
Impact of the refacto:
|
Contributor
Author
|
@PSeitz this PR is finally pretty much ready. Histogram benchmarks are a bit disappointing, I'll try to figure out why.
|
Contributor
Author
|
I found the issue with histograms. Fx Hash behaves very poorly with small round floats because the lower bits are usually constant (0), and that triggers a lot of collisions.
|
This was referenced Oct 29, 2025
PSeitz
reviewed
Nov 4, 2025
| get_all_ff_readers(reader, &source.field, Some(&allowed_column_types))?; | ||
|
|
||
| columns_and_types | ||
| .sort_by_key(|(_, col_type)| col_type_order_key(col_type, source.order)); |
Collaborator
There was a problem hiding this comment.
can we just sort them and if the order is reversed add .reverse?
Contributor
Author
There was a problem hiding this comment.
I admit that this part is over-complicating things a little bit. This sort works hand in hand with find_skip_idx() / skip_for_key() which assume an order where types other than bool/str/numeric are always at the end. Just reverting wouldn't work, but we can maybe find something simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.elastic.co/docs/reference/aggregations/search-aggregations-bucket-composite-aggregation
Composite aggregations are usefull to export pre-aggregated data at medium cardinailities (10k to millions).