Fix Send(Messagable) which does not account for TargetSubID & SenderSubID #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sylr If you added a test or two here to ensure accessing these fields in the header doesn't cause any issues here if they don't exist, I will merge it right away |
…ubID Signed-off-by: Sylvain Rabot <[email protected]>
sylr
changed the title
|
@ackleymi I've added a test as requested. |
|
@ackleymi could you please review this ? |
|
@ackleymi could you please tell me if you are interested in merging this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sylvain Rabot [email protected]