New title canonicalization for h1 is breaking custom rendering (using custom template and no boostrap) #11596
Description
New title canonicalization from
is a bit to eager for custom rendering lik pkgdown is doing. This has been found while investigating
This example recreates what pkgdown is doing
-
Take this custom template
template.html<!DOCTYPE html> <html lang="$lang$"> <body> <div class="meta"> $if(title)$ <h1>$title$</h1> $endif$ </div> <main> $body$ </main> </body> </html>
It does not use any of quarto partial and fully custom. pkgdown use something like this by taking the
$title$to put it in a specific div it can retrieve from -
Now use it a simple .qmd document like this
--- title: TESTING format: html: template: template.html minimal: true theme: none --- # Heading
The output will be the following after quarto render
<!DOCTYPE html>
<html lang="en"><head></head><body>
<div class="meta">
</div>
<main><header id="title-block-header" class="quarto-title-block"><h1 class="title">TESTING</h1></header>
<h1 id="heading">Heading</h1>
</main>
</body></html>Previous with Quarto 1.5
<!DOCTYPE html>
<html lang="en"><head></head><body>
<div class="meta">
<h1>TESTING</h1>
</div>
<main>
<h1 id="heading">Heading</h1>
</main>
</body></html>New addition from #11224 is applying here because all the checks are triggered
quarto-cli/src/format/html/format-html-title.ts
Lines 195 to 241 in 39baf40
#11224 was supposed to solve #10567 which seemed to be quite specific to breadcrumbs. So maybe the post processing applies to eagerly here.
- Should it apply on Project type website rendering only ?
- Should it apply only when no custom template as been passed ?
I see that this processing checks that .quarto-title-block exists and add it otherwise. I believe class is not always added in HTML document.
It is from this specific partial (and others) added only for bootstrap output
I mean when minimal: true or theme: pandoc or theme: none, I don't think there will be this class however the processing will add it.
There are many variation of title block also and this check