Make MTU configurable #493
Draft
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unlikely that this is the correct (or an acceptable) fix. Could you check whether this is a fixed bug (in booster main or #488 or addressed in a newer smoltcp)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #492, we finally discovered that a network segment was dropping packets from booster because of an MTU less than 1500. Since booster doesn't implement anything to react to ICMP MTU-related responses from the segment refusing to deliver the large frames, everything ends up being silently dropped. Because the telemetry packets all get bundled together at ~300B each, it only takes about 4 to hit the MTU, and trigger this behaviour.
Rather than implementing full MTU handling, in this PR I've added a configuration setting that allows the user to reduce the default 1500 MTU if they wish to, on a fixed basis.