Fix configs #11
Fix configs #11
Conversation
|
Hi @mwasilew, Thank you for raising the PR with QTAC team. Can you please summarize the commit messages in the PR into the PR description? Please use below pointers:
Please review the CONTRIBUTING.md guidelines and retarget the pull request to Regards, |
|
Thanks @Biswajee. I updated the merge message, but I think github doesn't allow to change the target branch. I'll repost it with proper branch. |
|
@mwasilew, you can edit the PR title to get the option to update the target branch. |
|
Ah, nice!. Let me rebase on top of develop so there are no conflicts |
mwasilew
force-pushed
the
fix_configs
branch
2 times, most recently
from
eaa5139 to
12a1ccb
Compare
|
I rebased the patches as described in CONTRIBUTING. The tests passed in my fork: https://github.com/mwasilew/qcom-test-automation-controller/actions/runs/18162492391 |
|
@mwasilew, per the CONTRIBUTING.md, is it possible that the PR contains only the changes made by you? It appears that this PR includes changes authored by me as well because the base branch for 
|
|
@Biswajee I think you're right. Let me redo the rebasing process, I think I followed the instructions but apparently I did something wrong. |
TAC_FTDI_19 uses $fastboot variable in the script. This variable is not defined in the configuration. This patch adds fastboot variable to the config file. Signed-off-by: Milosz Wasilewski <[email protected]>
There were 2 syntax errors in the script: - missing brackets after definition of bootToUEFI function - wrong indent in the body of the function Signed-off-by: Milosz Wasilewski <[email protected]>
Variable name in the variables section was "Optional_GPIO_Hold_time". At the same time script was using variable "Optional_GPIO_Hold_Time". This patch fixes the variable name in the variables section. Signed-off-by: Milosz Wasilewski <[email protected]>
|
@Biswajee the branching issue is fixed. I pushed new version |
2 participants
This series fixes the internal inconsistencies in the config files. There are 2 types of issues: