refactor: swap out uuid lib for native randomUUID #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimniels
commented
Apr 25, 2023
| "resolved": "file:quadratic-core/pkg", | ||
| "license": "MIT" | ||
| "resolved": "quadratic-core/pkg", | ||
| "link": true |
Collaborator
Author
There was a problem hiding this comment.
Not sure why these are changing? Is this problematic?
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Collaborator
Author
|
Turns out, the uuid is using the browser's native version of this where applicable uuidjs/uuid#600 So this probably isn't necessary. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a UUID via the browser's built-in
crypto.randomUUIDThis results in less JS code to ship to the client.
Resolves #421