Added BaseSamplerV2 support for Amplitude Estimation algorithms with StatevectorSampler #217
+112
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnurajendran
requested review from
Cryoris,
woodsp-ibm and
ElePT
as code owners
|
|
April 07, 2025
|
In regards of V2 support and Qiskit 2.0 I put a comment here in the issue raised to support 2.0. #224 (comment) |
|
I am going to close this PR as more broadly #197 updated all the algorithms code over to V2 primitives support which included these Amplitude Estimators as part of that PR. Thanks though for doing this - but I am closing this as its no longer relevant/needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains
will fix part of Support V2 primitives #136
Details and comments
Unlike the quasi-probability distributions returned by V1, V2 returns
PrimitiveResult[SamplerPubResult], this could mean one need a larger number of shots for accurate results. This should be taken care in test cases more carefully and I think improvements should be made for a new set of test.