Skip to content

Update docs and licence info #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2020
Merged

Update docs and licence info #47

merged 3 commits into from
Feb 9, 2020

Conversation

@saltysealion
Copy link
Contributor

@saltysealion saltysealion commented Feb 6, 2020

@saltysealion saltysealion changed the title Update docs and licence info [WIP] Update docs and licence info Feb 6, 2020
@stevegore
Copy link
Contributor

stevegore commented Feb 6, 2020

Thanks for this. Think you may still need to remove License from https://github.com/qctrl/python-open-controls/blob/DEVOPS-263/docs/index.rst ?

@saltysealion
Copy link
Contributor Author

saltysealion commented Feb 6, 2020

Thanks @stevegore. By the way,
WIP stands for work in progresss. I wouldn’t want you to spend more time on this when there are still a number of changes planned. If you really like, I can assign you to be a reviewer since this was originally a dev ops ticket? Let me know.

@saltysealion saltysealion changed the title [WIP] Update docs and licence info Update docs and licence info Feb 7, 2020
@michaelhush
Copy link
Contributor

michaelhush commented Feb 7, 2020

LGTM

The package could do with a brief description at the top of the documentation. But I'll make a task to add that after.

michaelhush
michaelhush previously approved these changes Feb 7, 2020
View reviewed changes
@stevegore
Copy link
Contributor

stevegore commented Feb 7, 2020

Sorry did not notice the WIP tag. FYI you can use GitHub's draft PR feature for this so that PR's can't be ready until explicitly marked as ready for review.

robertlove
robertlove approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@robertlove robertlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sitting next to you watching you do this so consider it reviewed.

@saltysealion saltysealion merged commit 103a7fc into master Feb 9, 2020
@saltysealion saltysealion deleted the DEVOPS-263 branch February 9, 2020 23:52
cfarrend added a commit that referenced this pull request Feb 11, 2020
@cfarrend
Revert "Merge pull request #47 from qctrl/DEVOPS-263"
6ab1c86 
This reverts commit 103a7fc, reversing
changes made to 2b9db5a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertlove robertlove robertlove approved these changes

@michaelhush michaelhush michaelhush left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saltysealion @stevegore @michaelhush @robertlove