Clean up the redundant arg_min/max releated file #5605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for preparing the follow up PR for #5586. LGTM pending on CI completion. |
lsy323
approved these changes
Sep 18, 2023
JackCaoG
approved these changes
Sep 18, 2023
Member
Author
|
This is the follow up with the discussion in #5586. We have switched to the codegen lowering method for arg_max and arg_min. So we can clean up the arg_min and arg_max related files and dependencies used in manual lowering. |
Member
Author
Collaborator
|
no.. it is just slow.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5583.