-
Notifications
You must be signed in to change notification settings - Fork 559
Codegen HardshrinkBackward and SoftshrinkBackward #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da0be9a to
dcd19cb
Compare
dcd19cb to
640ea5b
Compare
|
@vanbasten23, any reason why this is in draft? |
|
|
||
| xla::XlaOp BuildShrinkBackward(xla::XlaOp grad_output, xla::XlaOp input, | ||
| const at::Scalar& lambda) { | ||
| xla::XlaOp lambda) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we may want to do MaybeCast similar to 4ccfc24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I realized I haven't done the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
LazyIr.h:
XlaNativeFunctions.cpp: