Skip to content

Revert "Revert "Support torch.mean with dim=None (#3752)" (#3757)" #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Revert "Revert "Support torch.mean with dim=None (#3752)" (#3757)" #3782

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33cf8bf
Revert "Revert "Support torch.mean with dim=None (#3752)" (#3757)"
wonjoo-wj Jul 27, 2022
38cd9b7
Add torch pin
wonjoo-wj Jul 27, 2022
dc88931
Delete .torch_pin
wonjoo-wj Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions torch_patches/.torch_pin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#81286
11 changes: 7 additions & 4 deletions torch_xla/csrc/aten_xla_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1975,13 +1975,16 @@ at::Tensor XLANativeFunctions::mean(const at::Tensor& self,
/*keep_reduced_dimensions=*/false, dtype));
}

at::Tensor XLANativeFunctions::mean(const at::Tensor& self, at::IntArrayRef dim,
bool keepdim,
at::Tensor XLANativeFunctions::mean(const at::Tensor& self,
at::OptionalIntArrayRef dim, bool keepdim,
c10::optional<at::ScalarType> dtype) {
XLA_FN_COUNTER("xla::");
XLATensorPtr self_tensor = bridge::GetXlaTensor(self);
return bridge::AtenFromXlaTensor(XLATensor::mean(
bridge::GetXlaTensor(self), torch::lazy::ToVector<int64_t>(dim),
/*keep_reduced_dimensions=*/keepdim, dtype));
self_tensor,
dim ? torch::lazy::ToVector<int64_t>(*dim)
: torch::lazy::Iota<int64_t>(self_tensor->shape().get().rank()),
keepdim, dtype));
}

at::Tensor XLANativeFunctions::min(const at::Tensor& self) {
Expand Down