Skip to content

Conversation

@goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Jun 11, 2025

Run pre-commit to fix end-of-file-fixer and trailing-whitespace

This also adds a new file to store commits to remove form git blame commands with a note on how to use it locally.

.git-blame-ignore-revs

# Run this command to always ignore formatting commits in `git blame`
# git config blame.ignoreRevsFile .git-blame-ignore-revs

# Run pre-commit to fix end-of-file-fixer and trailing-whitespace



@vfdev-5 added https://github.com/pytorch/ignite/pull/3418/files#diff-f247fbfbe928b907db42554d0b3006b28dd11c25a59be031abda73b11a2c934a as suggested!

Also let me know if I should revert any of the changes, to some of the files (SVG, notebooks, etc)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 12, 2025

@goanpeca the way the PR is merged is squash all commits into a single commit, maybe the commit to ignore for git blame should be done after merging this one?

@goanpeca
Copy link
Collaborator Author

Done @vfdev-5 !

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca

@vfdev-5 vfdev-5 merged commit fe5a29b into pytorch:master Jun 12, 2025
10 checks passed
@goanpeca goanpeca deleted the enh/fix-line-endings-whitespace branch June 12, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants