This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Remove IRFunction requirement from CollectConstants #2290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickgg The IR is optional. Will your procedure work for backends that don't use the IR? |
|
@nadavrot Yes, this removes the requirement for the IR. |
nadavrot
approved these changes
Jan 23, 2019
rdzhabarov
reviewed
Jan 23, 2019
lib/Backends/BackendUtils.cpp
Outdated
There was a problem hiding this comment.
what is the situation when module does not have that constant?
There was a problem hiding this comment.
It's a consequence of the RuntimeBundle overlap issue you commented on in #2274, the SymbolTable contains both Constants and Placeholders. We only want to copy the contents of the Constants though, obviously.
nickgg
force-pushed
the
collectConstants
branch
from
2fa0056 to
6875e77
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Pulling the collectConstants process out of compile meant that we must do it later in the DeviceManager. Practically this would mean storing the IR representation in the CompiledFunction so we can pull out the weight tensors. Instead, we can refactor to use the RuntimeBundle and the Module (both of which we know we have in the DM) and remove the extra state.
Testing: unittests
Documentation: