Skip to content

Arm backend: Run pytest model tests in parallell #13322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Aug 12, 2025

Reduces time of pytest model jobs with ~50%. Upstream ci tested successfully 4 times, and easy to revert if it turns out to be flaky.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ifccccff659e7ce8f747d861e1c61942858bcdd35
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13322

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit df5ca62 with merge base 72580d2 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025
@Erik-Lundell Erik-Lundell added ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 12, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025
@Erik-Lundell Erik-Lundell changed the title WIP: Run pytest model tests in parallell Arm backend: Run pytest model tests in parallell Aug 13, 2025
@Erik-Lundell Erik-Lundell added the release notes: none Do not include this in the release notes label Aug 13, 2025
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Aug 13, 2025
@zingo zingo merged commit 910918e into pytorch:main Aug 13, 2025
613 of 618 checks passed
@@ -101,7 +101,7 @@ test_pytest_models() { # Test ops and other things
source backends/arm/scripts/install_models_for_test.sh

# Run arm baremetal pytest tests without FVP
pytest --verbose --color=yes --durations=0 backends/arm/test/models
pytest --verbose --color=yes --numprocesses=auto --durations=0 backends/arm/test/models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always assumed it would do this automatically after reading worker related messages. but this is good, I didn't realize --dist=no by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants