Arm backend: Initial int16 extension #13318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the possibility to add extension to the TOSA specification for the test pipeline. Signed-off-by: Per Åstrand <[email protected]> Change-Id: I64d8dcce3ea1bf6aa76230396690fd007974f792
Signed-off-by: Per Åstrand <[email protected]> Change-Id: I5782c5e337913319830e7c79f09a34d4227751c9
The sigmoid tests uses the EXT-INT16 of the TOSA 1.0 specification, so the extension must be used in the tests. Signed-off-by: Per Åstrand <[email protected]> Change-Id: Ie0d1a03d73e46139c6b6a0822736e2270e716650
per
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13318
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit e7421e1 with merge base baed71b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
zingo
approved these changes
Aug 13, 2025
|
Unrelated failures in test-models-arm-zephyr and build-demo-ios |
digantdesai
reviewed
Aug 14, 2025
| @@ -128,7 +128,7 @@ def ethosu_compile_spec( | |||
| self.compiler_flags.append("--output-format=raw") | |||
| self.compiler_flags.append("--debug-force-regor") | |||
|
|
|||
| base_tosa_version = "TOSA-1.0+INT" | |||
| base_tosa_version = "TOSA-1.0+INT+int16" | |||
There was a problem hiding this comment.
We have been using ts.DType.INT16 in a few places, how did that work without this flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add TOSA extension support for tests and add initial support for int16.
Test plan
Tested through unit tests in backends/arm.
cc @digantdesai @freddan80 @zingo @oscarandersson8218