Link Vulkan backend with pybinding lib when built #13309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as changes landed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Vulkan backend as a dependency to the pybinding build, when built. I've validated that I can run a simple Vulkan model on pybindings with this change on Mac (via MoltenVK).
Note that I'm not updating the preset to always build Vulkan yet. It requires additional dependencies and thus needs more discussion. I'm not sure if we can auto-install everything that we need. I'll get @SS-JIA's opinion on this. Also, once executorch::backends target is installable, I'll switch pybindings to use that target.
Tracking task: #12895.