Change arg order in lowbit linear ops to match aten #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/982
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2b1c17b with merge base 68e1886 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63422524 |
kirklandsign
approved these changes
Sep 30, 2024
digantdesai
approved these changes
Sep 30, 2024
|
This pull request was exported from Phabricator. Differential Revision: D63422524 |
metascroy
added a commit
to metascroy/ao
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: pytorch#982 Discussed with Manuel to align on arg order between CPU/MPS ops. Reviewed By: digantdesai, manuelcandales Differential Revision: D63422524
metascroy
force-pushed
the
export-D63422524
branch
from
eefdb2b to
abc37e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63422524 |
metascroy
added a commit
to metascroy/ao
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: pytorch#982 Discussed with Manuel to align on arg order between CPU/MPS ops. Reviewed By: digantdesai, manuelcandales Differential Revision: D63422524
metascroy
force-pushed
the
export-D63422524
branch
from
abc37e9 to
45e8444
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63422524 |
metascroy
added a commit
to metascroy/ao
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: pytorch#982 Discussed with Manuel to align on arg order between CPU/MPS ops. Reviewed By: digantdesai, manuelcandales Differential Revision: D63422524
metascroy
force-pushed
the
export-D63422524
branch
from
45e8444 to
9a62353
Compare
Summary: Pull Request resolved: pytorch#982 Discussed with Manuel to align on arg order between CPU/MPS ops. Reviewed By: digantdesai, manuelcandales Differential Revision: D63422524
|
This pull request was exported from Phabricator. Differential Revision: D63422524 |
metascroy
force-pushed
the
export-D63422524
branch
from
9a62353 to
2b1c17b
Compare
melvinebenezer
pushed a commit
to melvinebenezer/ao
that referenced
this pull request
Oct 7, 2024
Change arg order in lowbit linear ops to match aten (pytorch#982) Summary: Pull Request resolved: pytorch#982 Discussed with Manuel to align on arg order between CPU/MPS ops. Reviewed By: digantdesai, manuelcandales Differential Revision: D63422524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Discussed with Manuel to align on arg order between CPU/MPS ops.
Reviewed By: digantdesai, manuelcandales
Differential Revision: D63422524