use pytorch version env variable #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/373
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 58f23c2 with merge base bc2f8b7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
atalman
reviewed
Jun 15, 2024
| @@ -88,6 +88,16 @@ def get_extensions(): | |||
|
|
|||
| return ext_modules | |||
|
|
|||
| # Mimic code from torchvision https://github.com/pytorch/vision/blob/143d078b28f00471156a4e562dd3836370acc9ee/setup.py#L58 | |||
| pytorch_dep = "torch" | |||
| if os.getenv("PYTORCH_VERSION"): | |||
There was a problem hiding this comment.
Lgtm, would need to check in workflow that PYTORCH_VERSION is actually being set correcty when running nightly build
atalman
approved these changes
Jun 15, 2024
Closed
msaroufim
added a commit
that referenced
this pull request
Jun 15, 2024
This reverts commit aa61c45.
NicoleMayer
pushed a commit
that referenced
this pull request
Jul 9, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @atalman for finding this trick
Because this was the right incantation to make sure the fp6 kernels are correctly build and packaged using pypi