Skip to content

Graduate debug handle in torchao #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Conversation

Gasoonjia
Copy link
Contributor

Summary:
This diff maket torchao's debugging infra fully leverage node["from_node"] info and get rid of debug handle.

debug handle, we will miss you 🫡

Reviewed By: jerryzh168

Differential Revision: D76628702

Copy link

pytorch-bot bot commented Jun 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2452

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76628702

@Gasoonjia Gasoonjia added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Jun 27, 2025
Gasoonjia added a commit to Gasoonjia/ao that referenced this pull request Jun 27, 2025
Summary:

This diff maket torchao's debugging infra fully leverage node["from_node"] info and get rid of debug handle.

debug handle, we will miss you 🫡

Reviewed By: jerryzh168

Differential Revision: D76628702
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76628702

"""

name: str
graph_id: int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some comments here about what is graph_id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I see, is graph_id enough for operator level debugging?

Summary:

This diff maket torchao's debugging infra fully leverage node["from_node"] info and get rid of debug handle.

debug handle, we will miss you 🫡

Reviewed By: jerryzh168

Differential Revision: D76628702
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76628702

@Gasoonjia Gasoonjia merged commit 215dfb4 into pytorch:main Jun 27, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants