[ci] fix pt2e x86 unit tests #2371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It looks like this [change](pytorch/pytorch@61e1378#diff-40b3d6cc2026cae8f139b15c4b0b05fd2e69c2715be0ce15648de79b0e15a4eb) in core was made and the corresponding test change was not duplicated here. To unbreak CI, I copied over the test changes from the core PR, but I this just skips the test, a proper fix is still needed. Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2371
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1ec6a04 with merge base 03c850a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jcaip
added
the
topic: not user facing
|
cc @Xia-Weiwen hey just wanted to follow up on #2140 and see if you're planning to deprecate in core soon? |
jerryzh168
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It looks like this
change in core was made and the corresponding test change was not duplicated here.
To unbreak CI, I copied over the test changes from the core PR, but I this just skips the test, a proper fix is still needed.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: