Skip to content

Conversation

@lanluo-nvidia
Copy link
Collaborator

Description

Two changes:

  1. thor non_zero is fixed in trt 14, reenable back the converter and tests
  2. save engine to /tmp/trt.ep has side effect when run the tests in parallel in dlfw
    change to the unique tmp dir so that test run in parallel won't mixed up
    Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Nov 23, 2025
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review November 23, 2025 05:09
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 23, 2025
@github-actions github-actions bot requested a review from peri044 November 23, 2025 05:09
@lanluo-nvidia lanluo-nvidia added the Force All Tests[L0+L1+L2] For run all the L0, L1, L2 tests label Nov 23, 2025
@lanluo-nvidia lanluo-nvidia force-pushed the lluo/reenable_thor_test_new branch from eeae5a7 to 4a48032 Compare November 23, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests Force All Tests[L0+L1+L2] For run all the L0, L1, L2 tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants